style: change return to keep code style clean #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please fix CI. |
|
Please fix CI, rest LGTM @hawkingrei |
XuHuaiyu
reviewed
Jun 6, 2017
| @@ -395,7 +394,7 @@ func (b *builtinFromDaysSig) eval(row []types.Datum) (d types.Datum, err error) | |||
| } | |||
| days, err := args[0].ToInt64(b.ctx.GetSessionVars().StmtCtx) | |||
There was a problem hiding this comment.
The err is not handled, so CI failed. @hawkingrei
There was a problem hiding this comment.
@XuHuaiyu but I add error handler. CI still failed
…to fix/return_code_style
…to fix/return_code_style
XuHuaiyu
reviewed
Jun 6, 2017
expression/builtin_time.go
Outdated
| } | ||
| days, err := args[0].ToInt64(b.ctx.GetSessionVars().StmtCtx) | ||
| d.SetMysqlTime(types.TimeFromDays(days)) | ||
| return d, nil | ||
| return d, err |
There was a problem hiding this comment.
If args[0] is a string like "z500z",
ToInt64 will cause a TruncatedError,
thus, test case can not be passed if we change return d, nil to return d, err.
You can keep it return d, nil currently.
|
@XuHuaiyu PTAL |
|
LGTM |
XuHuaiyu
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep code style consistent