Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util, session: enable paging for more ut #36259

Merged
merged 11 commits into from
Jul 19, 2022

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

enable paging for more unit tests

Issue Number: ref #35633

Problem Summary:

What is changed and how it works?

Check List

Tests

  • No code

Side effects

N/A

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2022

@XuHuaiyu
Copy link
Contributor Author

/run-unit-tests

@hawkingrei
Copy link
Member

[2022/07/18 14:49:34.936 +08:00] [WARN] [2pc.go:1808] ["schemaLeaseChecker is not set for this transaction"] [sessionID=4] [startTS=434668037717622785] [checkTS=434668037717622786]
    distsql_test.go:478: 
        	Error Trace:	distsql_test.go:478
        	Error:      	Not equal: 
        	            	expected: 0x4
        	            	actual  : 0x1
        	Test:       	TestCoprocessorPagingSize

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

/run-integration-common-test

@XuHuaiyu
Copy link
Contributor Author

/run-common-test

@XuHuaiyu
Copy link
Contributor Author

/run-sqllogic-test

@XuHuaiyu
Copy link
Contributor Author

/run-mybatis-test

@XuHuaiyu
Copy link
Contributor Author

/run-tics-test

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests
/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests
/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 35cfe58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@XuHuaiyu
Copy link
Contributor Author

The failed case has nothing to do with this commit.

[2022-07-19T08:11:57.198Z]     testkit.go:85: 
[2022-07-19T08:11:57.198Z]         	Error Trace:	testkit.go:85
[2022-07-19T08:11:57.198Z]         	            				testkit.go:138
[2022-07-19T08:11:57.198Z]         	            				testkit.go:116
[2022-07-19T08:11:57.198Z]         	            				pessimistic_test.go:313
[2022-07-19T08:11:57.198Z]         	Error:      	Received unexpected error:
[2022-07-19T08:11:57.198Z]         	            	[tikv:9004]Resolve lock timeout
[2022-07-19T08:11:57.198Z]         	Test:       	TestFirstStatementFail

@XuHuaiyu
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit d48f40a into pingcap:master Jul 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 19, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 7 sec New failing
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 22 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 12 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 53 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 54 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants