log-backup: filter out unnecessary metadata files #36656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/888e8fbfac647337ab5c72e460f013d6b2835d81 |
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
ti-chi-bot
added
size/XL
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
|
/rebuild |
Leavrth
approved these changes
Jul 29, 2022
3pointer
approved these changes
Jul 29, 2022
| @@ -25,8 +26,7 @@ type StreamMetadataSet struct { | |||
| BeforeDoWriteBack func(path string, last, current *backuppb.Metadata) (skip bool) | |||
| } | |||
|
|
|||
| // LoadFrom loads data from an external storage into the stream metadata set. | |||
| func (ms *StreamMetadataSet) LoadFrom(ctx context.Context, s storage.ExternalStorage) error { | |||
| func (ms *StreamMetadataSet) LoadUntil(ctx context.Context, s storage.ExternalStorage, until uint64) error { | |||
There was a problem hiding this comment.
you can add some comments
ti-chi-bot
added
status/LGT2
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
|
/hold |
ti-chi-bot
added
the
do-not-merge/hold
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
|
/unhold |
ti-chi-bot
removed
the
do-not-merge/hold
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: cdafeff
|
ti-chi-bot
added
the
status/can-merge
|
/run-check_dev |
1 similar comment
|
/run-check_dev |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 29, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
1 task
|
cherry pick to release-6.2 in PR #36708 |
TiDB MergeCI notify
|
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #36648
Problem Summary:
Even we are going to truncate / restore a subset of all logs, the current implementation would try to read all metadata.
This may lead to OOM when there are too many meta files.
What is changed and how it works?
After this PR, when we executing
restore pointorlog truncate, we would filter out metadata that is obviously should not be considered. They are:For
restore point:MinTS > RestoreTS || MaxTS < ShiftedStartTSFor
log truncate:MinTS > UntilTSCheck List
Tests
The image above shows the different memory usage between restoring full log and restoring a subset of log.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.