Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table/tables: fix bug for jepsen test on cached table #37020

Merged
merged 20 commits into from Aug 16, 2022
Merged

table/tables: fix bug for jepsen test on cached table #37020

merged 20 commits into from Aug 16, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36885

Problem Summary:

What is changed and how it works?

There are two places err not returned, two places lease value decrease.

Check List

Tests

  • Unit test
  • Integration test

Integration jepsen test

  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2022
@tiancaiamao tiancaiamao mentioned this pull request Aug 10, 2022
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b120df15b30110d4c724510849838cffc21b11c9

@tiancaiamao tiancaiamao marked this pull request as ready for review August 16, 2022 06:46
tangenta
tangenta reviewed Aug 16, 2022
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2022
hawkingrei
hawkingrei reviewed Aug 16, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d84575

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2022
@ti-chi-bot ti-chi-bot merged commit 483183e into pingcap:master Aug 16, 2022
@tiancaiamao tiancaiamao deleted the cached-table branch August 16, 2022 09:04
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 16, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#37020 to release-6.0
10f26fc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #37146

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 16, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#37020 to release-6.1
b9de910 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37149

@sre-bot
Copy link
Contributor

sre-bot commented Aug 16, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 5 min 14 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 36 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 16, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#37020 to release-6.2
163dfc4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #37151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@lcwangchao lcwangchao lcwangchao approved these changes

@tangenta tangenta tangenta approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table cache may lead to inconsistency read
8 participants
@tiancaiamao @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @lcwangchao @tangenta @zyguan