-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix missing index names in stmt summary/slow log for [Batch]PointGet
#37073
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
[Batch]PointGet
/run-build |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/be8632d060a184691105649616ad726fb15155e7 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 881b9cd
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #37066
Problem Summary:
The display of index names for
PointGet
andBatchPointGet
is inconsistent inEXPLAIN
and the statements summary/slow log. In the statements summary and slow log, the index names are missing.What is changed and how it works?
Append the index names when building
PointGet
andBatchPointGet
, like we do when buildingIndexReader
,IndexLookUpReader
andIndexMergeReader
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.