util/goroutine_pool: add a goroutine pool package utilities #3752
Conversation
util/goroutine_pool/gp.go
Outdated
| @@ -0,0 +1,181 @@ | |||
| // Copyright 2016 PingCAP, Inc. | |||
util/goroutine_pool/gp_test.go
Outdated
| @@ -0,0 +1,131 @@ | |||
| // Copyright 2016 PingCAP, Inc. | |||
util/goroutine_pool/gp.go
Outdated
| ch: make(chan func()), | ||
| pool: pool, | ||
| } | ||
| go func(g *goroutine) { |
There was a problem hiding this comment.
I think defining a method for goroutine is more clear.
util/goroutine_pool/gp.go
Outdated
| return ret | ||
| } | ||
|
|
||
| func (pool *Pool) put(p *goroutine) { |
There was a problem hiding this comment.
This is called by goroutine in background, I think make this a goroutine method is more reasonable.
util/goroutine_pool/gp.go
Outdated
| } | ||
|
|
||
| func (pool *Pool) put(p *goroutine) { | ||
| p.next = nil |
There was a problem hiding this comment.
Isn't it always nil, encured by get?
util/goroutine_pool/gp.go
Outdated
|
|
||
| func (g *goroutine) put(pool *Pool) { | ||
| g.status = statusIdle | ||
| g.next = nil |
There was a problem hiding this comment.
Is it possible that g.next is not nil here?
|
|
||
| ret := head.next | ||
| head.next = ret.next | ||
| if ret == pool.tail { |
There was a problem hiding this comment.
pool.count--
if pool.count == 0 {
pool.tail = head
}
is easier to read.
There was a problem hiding this comment.
I didn't intent to maintain count, it's added later just for testing purpose.
util/goroutine_pool/gp.go
Outdated
| } | ||
| // Status already changed from statusIdle => statusDying, delete this goroutine. | ||
| if atomic.LoadInt32(&g.status) == statusDying { | ||
| g.status = statusDead |
There was a problem hiding this comment.
It seems no body cares about this value any more.
It can be removed.
util/goroutine_pool/gp.go
Outdated
| for { | ||
| g = pool.get() | ||
| if atomic.CompareAndSwapInt32(&g.status, statusIdle, statusInUse) { | ||
| break |
There was a problem hiding this comment.
I think just call
g.ch <-f and return here is easier to read.
There was a problem hiding this comment.
It's easier to read indeed, but there is a potential race condition.
util/goroutine_pool/gp_test.go
Outdated
| } | ||
|
|
||
| func TestRace(t *testing.T) { | ||
| gp := New(200 * time.Millisecond) |
There was a problem hiding this comment.
Isn't the timeout too long to test race?
tiancaiamao
force-pushed
the
tiancaiamao/goroutine-pool
branch
from
ec66a8f
to
ecf54ca
Compare
|
LGTM |
Reuse goroutine in a pool can avoid
runtime.morestack. It may be useful sometimes.