Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan, executor_test: fix bug for user variable. #3776

Merged
merged 4 commits into from
Jul 17, 2017
Merged

plan, executor_test: fix bug for user variable. #3776

merged 4 commits into from
Jul 17, 2017

Conversation

hanfei1991
Copy link
Member

fix #3774

@hanfei1991 hanfei1991 added the type/bugfix This PR fixes a bug. label Jul 17, 2017
@@ -231,6 +231,11 @@ func (s *testSuite) TestJoin(c *C) {
_, err = tk.Exec("select /*+ TIDB_INLJ(t) TIDB_SMJ(t) */ * from t join t1 on t.a=t1.a")
c.Assert(err, NotNil)

tk.MustExec("drop table if exists t, t1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop t1 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake.

@shenli
Copy link
Member

shenli commented Jul 17, 2017

LGTM

@shenli
Copy link
Member

shenli commented Jul 17, 2017

@XuHuaiyu @zimulala PTAL

@hanfei1991 hanfei1991 added status/LGT1 Indicates that a PR has LGTM 1. priority/P1 The issue has P1 priority. labels Jul 17, 2017
@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 17, 2017
@XuHuaiyu
Copy link
Contributor

LGTM

@shenli shenli merged commit 2578ae1 into master Jul 17, 2017
@shenli shenli deleted the hanfei/var branch July 17, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local variable assignment dosen't take effect in join statement.
3 participants