New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDL: Fix bug that TiFlash replica unavailable after add partition with small probability #39170
Conversation
Signed-off-by: hehechen <chentongli@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @windtalker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5f23ff7
|
In response to a cherrypick label: new pull request created: #39195. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What problem does this PR solve?
Issue Number: close #39171
Problem Summary:
There is a small probability that TiFlash replica unavailable after add partition.
refreshTiFlashTicker
don't check if logical table is available, so if a partition has been added inAddingDefinitions
oftableInfo
, and have not been added inAvailablePartitionIDs
, andrefreshTiFlashTicker
is executed at this time, this new added partition will be considered unavailable, so it will get TiFlash replica progress and then updateavailable
of the logical table.What is changed and how it works?
Check if logical table is available in
refreshTiFlashTicker
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.