-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDL: Fix bug that TiFlash replica unavailable after add partition with small probability (#39170) #39195
DDL: Fix bug that TiFlash replica unavailable after add partition with small probability (#39170) #39195
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hehechen <chentongli@pingcap.com>
/cherry-pick-invite |
@hehechen you're already a collaborator in repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-tests |
/retest |
1 similar comment
/retest |
/merge |
/merge |
@breezewish: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 195092b
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
This is an automated cherry-pick of #39170
What problem does this PR solve?
Issue Number: close #39171
Problem Summary:
There is a small probability that TiFlash replica unavailable after add partition.
refreshTiFlashTicker
don't check if logical table is available, so if a partition has been added inAddingDefinitions
oftableInfo
, and have not been added inAvailablePartitionIDs
, andrefreshTiFlashTicker
is executed at this time, this new added partition will be considered unavailable, so it will get TiFlash replica progress and then updateavailable
of the logical table.What is changed and how it works?
Check if logical table is available in
refreshTiFlashTicker
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.