Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL: Fix bug that TiFlash replica unavailable after add partition with small probability (#39170) #39195

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39170

What problem does this PR solve?

Issue Number: close #39171

Problem Summary:
There is a small probability that TiFlash replica unavailable after add partition.
refreshTiFlashTicker don't check if logical table is available, so if a partition has been added in AddingDefinitions of tableInfo, and have not been added in AvailablePartitionIDs, and refreshTiFlashTicker is executed at this time, this new added partition will be considered unavailable, so it will get TiFlash replica progress and then update available of the logical table.

What is changed and how it works?

Check if logical table is available in refreshTiFlashTicker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: hehechen <chentongli@pingcap.com>
@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@hehechen you're already a collaborator in repo ti-chi-bot/tidb

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 9, 2023
@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/cc @breezewish @windtalker @CalvinNeo

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2023
@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/run-all-tests

@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/run-tests

@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/retest

1 similar comment
@hehechen
Copy link
Contributor

hehechen commented Jan 9, 2023

/retest

@breezewish
Copy link
Member

/merge

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@breezewish: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 16, 2023
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 195092b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 16, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot merged commit 67705e6 into pingcap:release-6.1 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants