expression: rewrite builtin function: YEAR, MONTH #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Aug 17, 2017
expression/builtin_time.go
Outdated
| d, err = convertToTime(b.ctx.GetSessionVars().StmtCtx, args[0], mysql.TypeDate) | ||
| if err != nil || d.IsNull() { | ||
| return d, errors.Trace(err) | ||
| if isNull || err != nil { |
There was a problem hiding this comment.
It looks like isNull has a higher priority for these functions.
if isNull {
return
}
if err {
appendwarning(err)
return
}
may be more clear?
There was a problem hiding this comment.
in mysql:
MySQL > create table t(a bigint);
Query OK, 0 rows affected (0.02 sec)
MySQL > insert into t select year("aa");
ERROR 1292 (22007): Incorrect datetime value: 'aa'
MySQL > select year("aa");
+------------+
| year("aa") |
+------------+
| NULL |
+------------+
1 row in set, 1 warning (0.00 sec)seems mysql will throw this error during insert/update/delete, it will be solved in #4208
There was a problem hiding this comment.
mysql> set sql_mode = '';
Query OK, 0 rows affected, 1 warning (0.00 sec)
mysql> create table t (a bigint);
Query OK, 0 rows affected (0.01 sec)
mysql> insert into t select year("aa");
Query OK, 1 row affected, 1 warning (0.01 sec)
Records: 1 Duplicates: 0 Warnings: 1
mysql> show warnings;
+---------+------+--------------------------------+
| Level | Code | Message |
+---------+------+--------------------------------+
| Warning | 1292 | Incorrect datetime value: 'aa' |
+---------+------+--------------------------------+
1 row in set (0.00 sec)
It seems it relies on sql_mode in mysql.
jackysp
reviewed
Aug 22, 2017
| @@ -167,28 +170,31 @@ func (s *testEvaluatorSuite) TestDate(c *C) { | |||
| YearWeek interface{} | |||
| }{ | |||
| {nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil}, | |||
| {"0000-00-00", int64(0), int64(0), nil, int64(0), nil, nil, nil, nil, nil, nil, nil}, | |||
| {"0000-00-00 00:00:00", nil, nil, nil, int64(0), nil, nil, nil, nil, nil, nil, nil}, | |||
There was a problem hiding this comment.
Why change this instead of add a test?
XuHuaiyu
reviewed
Aug 22, 2017
| @@ -943,6 +943,46 @@ func (s *testIntegrationSuite) TestTimeBuiltin(c *C) { | |||
| result := tk.MustQuery("select makedate(a,a), makedate(b,b), makedate(c,c), makedate(d,d), makedate(e,e), makedate(f,f), makedate(null,null), makedate(a,b) from t") | |||
| result.Check(testkit.Rows("2001-01-01 2001-01-01 <nil> <nil> <nil> 2021-01-21 <nil> 2001-01-01")) | |||
|
|
|||
| // for year | |||
| result = tk.MustQuery(`select year("2013-01-09"), year("2013-00-09"), year("000-01-09"), year("1-01-09"), year("20131-01-09"), year(null);`) | |||
There was a problem hiding this comment.
add test for "2013-00-00", "2013-00-00 00:00:00", "0000-00-00 12:12:12", "2017-00-00 12:12:12"
so as month
|
@jackysp PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to #4080