Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: fix routine/client leak when get a cached store #42779

Merged
merged 8 commits into from
Apr 4, 2023
Merged

store: fix routine/client leak when get a cached store #42779

merged 8 commits into from
Apr 4, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Apr 3, 2023

What problem does this PR solve?

Issue Number: close #42778

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • return error after create spkv and store, check there should not have routine leak
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix routine/client leak when get a cached store

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/check-issue-triage-complete

D3Hunter
D3Hunter commented Apr 3, 2023
View reviewed changes
tests/realtikvtest/txntest/isolation_test.go
)

func TestGetCachedStore(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need real tikv to test it, so put it here

lance6716
lance6716 reviewed Apr 3, 2023
View reviewed changes
tests/realtikvtest/txntest/isolation_test.go
require.NoError(t, err)
require.Equal(t, store1, store2)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add goleak.VerifyTestMain to TestMain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already has it in main_test.go in this package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I supposed realtikvtest.RunTestMain(m) should have detected this leak. Maybe we can remove some IgnoreTopFunction now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're not in the list, like github.com/tikv/pd/client.(*client).handleResourceTokenDispatcher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous, there's no test case to get the store twice, but in physical mode we will get one.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

1 similar comment
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 4, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link
Member

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e83b723

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 4, 2023
@hawkingrei
Copy link
Member

/test all

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/retest

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 4, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45e255f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 4, 2023
@ti-chi-bot ti-chi-bot merged commit 38a0852 into master Apr 4, 2023
@ti-chi-bot ti-chi-bot deleted the fix-client-leak branch April 4, 2023 07:51
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 4, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42806.

@ti-chi-bot
Copy link
Member

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test ab89d5d link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #46143.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 16, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 18, 2023
@ti-chi-bot
store: fix routine/client leak when get a cached store (#42779) (#46143)
189e059 
close #42778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.0 release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

routine/client leak when get a cached store
5 participants
@D3Hunter @ti-chi-bot @hawkingrei @lance6716 @tangenta