Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: fix routine/client leak when get a cached store (#42779) #46143

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #42779

What problem does this PR solve?

Issue Number: close #42778

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • return error after create spkv and store, check there should not have routine leak
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix routine/client leak when get a cached store

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-42779-to-release-6.5 branch from 65dc8b0 to 1421b3a Compare August 16, 2023 08:44
@HuSharp
Copy link
Contributor

HuSharp commented Aug 16, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 16, 2023

@HuSharp: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@24f435b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46143   +/-   ##
================================================
  Coverage               ?   73.6846%           
================================================
  Files                  ?       1084           
  Lines                  ?     347903           
  Branches               ?          0           
================================================
  Hits                   ?     256351           
  Misses                 ?      75098           
  Partials               ?      16454           

@HuSharp
Copy link
Contributor

HuSharp commented Aug 17, 2023

@D3Hunter PTAL, thx!

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-42779-to-release-6.5 branch from 94796b7 to aae73d8 Compare August 17, 2023 09:25
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor

HuSharp commented Aug 17, 2023

cherry-pick #42885 as well, which resulted from #42779

@HuSharp
Copy link
Contributor

HuSharp commented Aug 17, 2023

update client-go to sync related pr tikv/client-go#944
can check more detail in pr description

for cp #42779 and #42885 PTAL, thx! @D3Hunter @hawkingrei
for client-go update, PTAL, thx! @nolouch @lhy1024

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 17, 2023
@HuSharp
Copy link
Contributor

HuSharp commented Aug 17, 2023

/retest-required

@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-17 16:55:01.037611848 +0000 UTC m=+822865.586627835: ☑️ agreed by nolouch.
  • 2023-08-18 01:57:45.739542601 +0000 UTC m=+855430.288558588: ☑️ agreed by D3Hunter.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 189e059 into pingcap:release-6.5 Aug 18, 2023
3 checks passed
@HuSharp HuSharp deleted the cherry-pick-42779-to-release-6.5 branch August 18, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants