parser, expression: implement builtin LAST_DAY #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master code
Code Merge
zz-jason
reviewed
Aug 22, 2017
expression/builtin_time.go
Outdated
| } | ||
| bf, err := newBaseBuiltinFuncWithTp(args, ctx, tpTime, tpTime) | ||
| bf.tp.Tp, bf.tp.Flen, bf.tp.Decimal = mysql.TypeDate, mysql.MaxDateWidth, types.DefaultFsp | ||
| if err != nil { |
There was a problem hiding this comment.
move the error check up, just after newBaseBuiltinFuncWithTp
shenli
reviewed
Aug 22, 2017
parser/parser.y
Outdated
| @@ -372,6 +372,7 @@ import ( | |||
| toBase64 "TO_BASE64" | |||
| toDays "TO_DAYS" | |||
| toSeconds "TO_SECONDS" | |||
| lastDay "LAST_DAY" | |||
| @@ -103,6 +103,10 @@ func (t mysqlTime) GoTime(loc *gotime.Location) (gotime.Time, error) { | |||
| return tm, nil | |||
| } | |||
|
|
|||
| func (t mysqlTime) IsLeapYear() bool { | |||
|
Please resolve the conflicts. |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4080
details about 'LAST_DAY', see: https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_last-day