New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, expression: implement builtin LAST_DAY #4290

Merged
merged 34 commits into from Aug 23, 2017

Conversation

Projects
None yet
4 participants
@spongedu
Contributor

spongedu commented Aug 22, 2017

spongedu added some commits Mar 21, 2017

Merge pull request #3 from pingcap/master
Merge master code
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated parser/parser.y Outdated
@@ -103,6 +103,10 @@ func (t mysqlTime) GoTime(loc *gotime.Location) (gotime.Time, error) {
return tm, nil
}
func (t mysqlTime) IsLeapYear() bool {

This comment has been minimized.

@shenli

shenli Aug 22, 2017

Member

Please add unit test for this.

@shenli

shenli Aug 22, 2017

Member

Please add unit test for this.

This comment has been minimized.

@spongedu

spongedu Aug 23, 2017

Contributor

done

@spongedu

spongedu Aug 23, 2017

Contributor

done

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Aug 23, 2017

Member

Please resolve the conflicts.

Member

jackysp commented Aug 23, 2017

Please resolve the conflicts.

@jackysp jackysp removed the conflicting label Aug 23, 2017

@jackysp

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Aug 23, 2017

@zz-jason zz-jason merged commit 31819a8 into pingcap:master Aug 23, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:builtin_lastday branch Aug 23, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment