Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/cmd: implement the operator pause-gc-and-schedulers command #43562

Merged
merged 7 commits into from May 10, 2023
Merged

br/cmd: implement the operator pause-gc-and-schedulers command #43562

merged 7 commits into from May 10, 2023

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented May 5, 2023 •
edited

What problem does this PR solve?

Issue Number: ref #43559
Problem Summary:
This PR implements the new (hidden) command "br operator pause-gc", which blocks the shell and then pause the global GC safepoint.
There are two flags for this command:
--safepoint or -t, the GC safepoint to be kept, default current resolved ts.
--ttl or -i, how long the service safe point lives, default 5 mins.

What is changed and how it works?

This PR just reused the StartServiceGcSafePointKeeper.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    (It is not easy to auto test this PR.)
    Firstly, we paused the safepoint.

image

The metrics shows that the safepoint has been kept.

image

This test also applies to the schedulers.

image

  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@YuJuncen
cherry-pick
9a2f7c9 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
make clippy happy
e9bda58 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 5, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • BornChanger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2023
@YuJuncen
fix lint
02c58ad 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
rename the command to pause-gc-and-schedulers
aee73ee 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023
@YuJuncen YuJuncen changed the title br/cmd: implement the operator pause-gc command br/cmd: implement the operator pause-gc-and-schedulers command May 6, 2023
This was referenced May 6, 2023
Merged
Merged
Closed
Merged
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023
@YuJuncen
Copy link
Contributor Author

YuJuncen commented May 8, 2023

/retest-required

@YuJuncen
make bazel_prepare
e484d5c 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
Merge branch 'master' of https://github.com/pingcap/tidb into operato…
ba5a542 
…r-cmds

Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
Copy link
Contributor Author

YuJuncen commented May 8, 2023

/retest-required

3pointer
3pointer reviewed May 9, 2023
View reviewed changes
br/pkg/task/operator/cmd.go Outdated Show resolved Hide resolved
br/pkg/task/operator/cmd.go Show resolved Hide resolved
br/pkg/task/operator/cmd.go Show resolved Hide resolved
br/pkg/task/operator/cmd.go Show resolved Hide resolved
@YuJuncen
address comments
fca8160 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2023
BornChanger
BornChanger reviewed May 9, 2023
View reviewed changes
br/cmd/br/main.go
@@ -49,6 +49,7 @@ func main() {
NewBackupCommand(),
NewRestoreCommand(),
NewStreamCommand(),
newOpeartorCommand(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
newOpeartorCommand(),
NewOpeartorCommand(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be public function. 🤔️

@BornChanger
Copy link
Contributor

/retest

@YuJuncen YuJuncen requested a review from BornChanger May 9, 2023 08:42
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2023
@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: fca8160

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2023
@YuJuncen
Copy link
Contributor Author

/retest

3 similar comments
@YuJuncen
Copy link
Contributor Author

/retest

@YuJuncen
Copy link
Contributor Author

/retest

@YuJuncen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ce1b6f9 into pingcap:master May 10, 2023
17 checks passed
@YuJuncen YuJuncen mentioned this pull request May 10, 2023
Merged
1 task
@BornChanger BornChanger mentioned this pull request May 10, 2023
Open
97 tasks
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
4 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43924.

@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
4 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43925.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 17, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of pingcap#43562
0711c54 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced May 17, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 18, 2023
@ti-chi-bot
br/cmd: implement the operator pause-gc-and-schedulers command (#43562
92bcef1 
) (#43924)

ref #43559
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
br/cmd: implement the operator pause-gc-and-schedulers command (#43562
d20a564 
) (#43925)

ref #43559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@BornChanger BornChanger BornChanger approved these changes

@WangLe1321 WangLe1321 Awaiting requested review from WangLe1321

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YuJuncen @BornChanger @ti-chi-bot @3pointer