br/backup_ebs: added flag operator-paused-gc-and-scheduler. (#43687)
#43926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hillium <yujuncen@pingcap.com>
1 task
ti-chi-bot
added
release-note-none
size/L
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
VelocityLight
added
cherry-pick-approved
YuJuncen
approved these changes
May 18, 2023
3pointer
approved these changes
May 18, 2023
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e982138
|
ti-chi-bot
bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #43687
What problem does this PR solve?
Issue Number: ref #43559
Problem Summary:
After #43562, we get the ability of pausing GC and schedulers in an external pod. But the backup command still tries to pause them, which is not really effective and will bring the ABA problem. (Say, some of BRs think the state of "no scheduler exists" is the original state of the cluster.)
What is changed and how it works?
This PR added a new hidden flag
--operator-paused-gc-and-scheduler. Once it set, the client will no longer try to pause scheduler (Should / Is it possible to further check whether they are really paused?) and start backup directly after the pending split done.Check List
Tests
Run command:
br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws -u http://upd-1:2379 -s noop://The schedulers are paused.
Run command:
br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws --operator-paused-gc-and-scheduler -u http://upd-1:2379 -s noop://The schedulers are not paused.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.