Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: ignore non-found partitions in inner joins #43763

Merged
merged 3 commits into from May 15, 2023
Merged

executor: ignore non-found partitions in inner joins #43763

merged 3 commits into from May 15, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented May 12, 2023 •
edited

What problem does this PR solve?

Issue Number: close #43686

Problem Summary:
When doing pruning for inner join lookup it propagated errors of not found partition instead of ignoring it (since there are no matching values).

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/invalid-title size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@mjonss mjonss changed the title Ignore ErrNoPartitionForGivenValue errors in prunePartitionForInnerEx… executor: ignore non-found partitions in inner joins May 12, 2023
bb7133
bb7133 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3491479

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2023
@bb7133
Copy link
Member

bb7133 commented May 15, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit cb17551 into pingcap:master May 15, 2023
8 checks passed
@mjonss mjonss deleted the on-missing-43686 branch May 15, 2023 10:35
@bb7133
Copy link
Member

bb7133 commented May 15, 2023

/cherry-pick release-6.5-20230425-v6.5.2

@ti-chi-bot ti-chi-bot mentioned this pull request May 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@bb7133: new pull request created to branch release-6.5-20230425-v6.5.2: #43838.

In response to this:

/cherry-pick release-6.5-20230425-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 15, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#43763
9c7d20e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
bb7133 pushed a commit to bb7133/tidb that referenced this pull request May 15, 2023
@mjonss @bb7133
executor: ignore non-found partitions in inner joins (pingcap#43763)
963050c 
close pingcap#43686
@bb7133 bb7133 mentioned this pull request May 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2023
@bb7133
executor: ignore non-found partitions in inner joins (#43763) (#43845)
182b447 
close #43686
@bb7133
Copy link
Member

bb7133 commented May 17, 2023

/cherry-pick

@bb7133
Copy link
Member

bb7133 commented May 17, 2023

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@bb7133: new pull request created to branch release-7.1: #43919.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
executor: ignore non-found partitions in inner joins (#43763) (#43919)
53aa3fa 
close #43686
@mjonss
Copy link
Contributor Author

mjonss commented May 30, 2023

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@mjonss: new pull request created to branch release-6.5: #44275.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 30, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#43763
84f5645 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
executor: ignore non-found partitions in inner joins (#43763) (#44275)
09be022 
close #43686
@AilinKid AilinKid mentioned this pull request Jun 5, 2023
Merged
12 tasks
This was referenced Jun 5, 2023
Closed
Open
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: dynamic partition prune should be aware of the caller‘s on-missing action
5 participants
@mjonss @Defined2014 @bb7133 @ti-chi-bot @tiancaiamao