Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Fix a bug when have a lot of jobs in upgrading state #44162

Merged
merged 4 commits into from May 25, 2023
Merged

*: Fix a bug when have a lot of jobs in upgrading state #44162

merged 4 commits into from May 25, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented May 25, 2023 •
edited

What problem does this PR solve?

Issue Number: close #44159

Problem Summary:

What is changed and how it works?

When we into the upgrading state we can do the CannotPauseDDLJob jobs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below
    As slowly pause user ddl will let tidb upgrade failed #44159
    deploy a cluster add do large ddl in queueing
    upgrade the cluster
    Before this PR, can't upgrade successfully
    After this PR, can upgrade successfully
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zimulala zimulala added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023
@zimulala zimulala requested a review from a team as a code owner May 25, 2023 03:45
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 25, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2023
@zimulala zimulala changed the title *: add logs [FOR TEST] *: Fix a bug when have a lot of jobs in upgrading state May 25, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot May 25, 2023
@dhysum
Copy link
Contributor

dhysum commented May 25, 2023

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. do-not-merge/needs-triage-completed and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-linked-issue labels May 25, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot May 25, 2023
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c8b6c9f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@zimulala
*: Fix a bug when have a lot of jobs in upgrading state(#44162) (#44172)
904a40e 
close #44159
@ti-chi-bot ti-chi-bot bot merged commit 8215c5c into pingcap:master May 25, 2023
8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #44162 on top of branch "release-7.1":

failed to git commit: exit status 1

@zimulala zimulala deleted the zimuxia/fix-restart branch May 26, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhysum dhysum dhysum left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slowly pause user ddl will let tidb upgrade failed
5 participants
@zimulala @dhysum @ti-chi-bot @XuHuaiyu @tangenta