New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types, plan: return ErrInvalidDefault when date type column option of create table statement has a now() default value #4430

Merged
merged 8 commits into from Sep 5, 2017

Conversation

Projects
None yet
4 participants
@winkyao
Member

winkyao commented Sep 4, 2017

for #4429

types, plan: return ErrInvalidDefault when date type column option of…
… create table statement has a now() default value
@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 4, 2017

Show outdated Hide outdated plan/validator.go
Show outdated Hide outdated plan/validator.go
@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 5, 2017

@coocood PTAL

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 5, 2017

Member

LGTM

Member

coocood commented Sep 5, 2017

LGTM

Show outdated Hide outdated util/types/errors.go
Show outdated Hide outdated plan/validator.go
Show outdated Hide outdated plan/validator.go
Show outdated Hide outdated plan/validator.go

@XuHuaiyu XuHuaiyu added the status/LGT2 label Sep 5, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Sep 5, 2017

Member

/run-all-test

Member

winkyao commented Sep 5, 2017

/run-all-test

@zz-jason zz-jason merged commit 75230f9 into master Sep 5, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the winkyao/default_now_date_type branch Sep 5, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

types, plan: return ErrInvalidDefault when date type column option of…
… create table statement has a now() default value (#4430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment