util/ranger: consider good non-point ranges from CNF item #44384
Conversation
ti-chi-bot
bot
added
the
size/M
ti-chi-bot
bot
added
size/L
xuyifangreeneyes
changed the title
xuyifangreeneyes
requested review from
qw4990,
winoros,
time-and-fate and
hawkingrei
util/ranger/detacher.go
Outdated
| if i == 0 { | ||
| maxColNum = len(ran.LowVal) | ||
| minColNum = len(ran.LowVal) | ||
| } else { | ||
| if len(ran.LowVal) > maxColNum { | ||
| maxColNum = len(ran.LowVal) | ||
| } | ||
| if len(ran.LowVal) < minColNum { | ||
| minColNum = len(ran.LowVal) | ||
| } | ||
| } |
There was a problem hiding this comment.
We can initiate minColNum with MaxInt and then use Max and Min to make the code simpler.
[LGTM Timeline notifier]Timeline:
|
|
/merge |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrysan, qw4990, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrysan, qw4990, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #44389
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.