Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/ranger: consider good non-point ranges from CNF item (#44384) #44397

Merged
merged 1 commit into from
Jun 5, 2023
Merged

util/ranger: consider good non-point ranges from CNF item (#44384) #44397

merged 1 commit into from
Jun 5, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44384

What problem does this PR solve?

Issue Number: close #44389

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner June 5, 2023 02:46
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 labels Jun 5, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elsa0520
elsa0520 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@elsa0520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuyifangreeneyes
Copy link
Contributor

/test check-dev2

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-05 03:11:30.477520399 +0000 UTC m=+231476.750493183: ☑️ agreed by chrysan.
  • 2023-06-05 03:32:09.462959033 +0000 UTC m=+232715.735931817: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

@xuyifangreeneyes
Copy link
Contributor

/merge

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@chrysan chrysan chrysan approved these changes

@qw4990 qw4990 qw4990 approved these changes

@elsa0520 elsa0520 elsa0520 approved these changes

Assignees

@xuyifangreeneyes xuyifangreeneyes

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ti-chi-bot @xuyifangreeneyes @hawkingrei @chrysan @qw4990 @elsa0520 @VelocityLight