Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: more test cases on admin pause/resume #44783

Merged
merged 27 commits into from Jun 28, 2023
Merged

ddl: more test cases on admin pause/resume #44783

merged 27 commits into from Jun 28, 2023

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented Jun 19, 2023 •
edited

What problem does this PR solve?

Issue Number: close #44762

Problem Summary:
a. Add more DDL statements to test admin pause/resume/cancel
b. Add more cases on admin pause/resume/cancel

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

Hi @dhysum. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhysum dhysum changed the title Dev/admin pause resume cases ddl: more test cases on admin pause/resume Jun 19, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from ac16faf to 3b59329 Compare June 19, 2023 09:44
@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 7defc0b to 4f16acf Compare June 20, 2023 03:28
@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 6016cef to 1396e98 Compare June 20, 2023 08:15
ywqzzy
ywqzzy reviewed Jun 20, 2023
View reviewed changes
ddl/adminpausetest/ddl_data_generation.go Outdated Show resolved Hide resolved
ddl/adminpausetest/ddl_data_generation.go Outdated Show resolved Hide resolved
ddl/adminpausetest/ddl_stmt_cases.go Outdated Show resolved Hide resolved
ddl/adminpausetest/global.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 1396e98 to 22c88d6 Compare June 20, 2023 12:01
@Benjamin2037 Benjamin2037 mentioned this pull request Jun 20, 2023
Closed
5 tasks
@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 22c88d6 to 7e4e90c Compare June 21, 2023 03:46
hawkingrei
hawkingrei reviewed Jun 21, 2023
View reviewed changes
ddl/ddl.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 9925c20 to 8bc667a Compare June 25, 2023 04:58
@hawkingrei
Copy link
Member

/test tiprow_fast_test

@pingcap pingcap deleted a comment from ti-chi-bot bot Jun 25, 2023
@dhysum
Copy link
Contributor Author

dhysum commented Jun 25, 2023

/retest

3 similar comments
@dhysum
Copy link
Contributor Author

dhysum commented Jun 25, 2023

/retest

@dhysum
Copy link
Contributor Author

dhysum commented Jun 26, 2023

/retest

@dhysum
Copy link
Contributor Author

dhysum commented Jun 26, 2023

/retest

@dhysum dhysum force-pushed the dev/admin_pause_resume_cases branch from 7ab5099 to d042c2a Compare June 28, 2023 02:51
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-27 11:07:53.818266093 +0000 UTC m=+705839.219516599: ☑️ agreed by hawkingrei.
  • 2023-06-28 03:32:02.201804635 +0000 UTC m=+764887.603055069: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 03495aa into pingcap:master Jun 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy left review comments

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestDDLCallback
4 participants
@dhysum @hawkingrei @tangenta @ywqzzy