Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix the value of MaxColumnID in memDB #45764

Merged
merged 2 commits into from Aug 4, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 2, 2023

What problem does this PR solve?

Issue Number: close #45744

Problem Summary:
At present, it is the MaxColumnID of the table in the information_schema database, which affects modify column, add column(this action has no problem in behavior, but can cause problems with column ids that are not unique)
.
The table under metrics_schema has a similar problem, and the table under performance_schema does not.

What is changed and how it works?

  • Set tables' MaxColumnID in the information_schema and metrics_schema databases.
  • Set tables' MaxIndexD, although this field is not currently used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
@tiprow
Copy link

tiprow bot commented Aug 2, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #45764 (558f3ec) into master (697652f) will increase coverage by 0.4296%.
Report is 39 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45764        +/-   ##
================================================
+ Coverage   73.2280%   73.6576%   +0.4296%     
================================================
  Files          1265       1274         +9     
  Lines        389826     396070      +6244     
================================================
+ Hits         285462     291736      +6274     
+ Misses        86064      86045        -19     
+ Partials      18300      18289        -11     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.6500% <100.0000%> (+0.4219%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (-0.0059%) ⬇️
br 52.0998% <ø> (-0.0143%) ⬇️

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 2, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 03:28:04.636104796 +0000 UTC m=+328768.578453314: ☑️ agreed by Defined2014.
  • 2023-08-04 06:05:25.783218506 +0000 UTC m=+424609.725567037: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit b6d92f5 into pingcap:master Aug 4, 2023
13 of 18 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #45817.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #45818.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45819.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@zimulala zimulala deleted the zimuxia/mem-db branch September 11, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alter table error : Invalid %!!(string=column)s(MISSING) state: %!!(model.SchemaState=5)v(MISSING)
5 participants