Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix incorrect _tidb_rowid allocator value after import for table with AUTO_ID_CACHE=1 (#46171) #46210

Merged
merged 3 commits into from Aug 18, 2023
Merged

lightning: fix incorrect _tidb_rowid allocator value after import for table with AUTO_ID_CACHE=1 (#46171) #46210

merged 3 commits into from Aug 18, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46171

What problem does this PR solve?

Issue Number: close #46100

Problem Summary:

since TiDB v6.5.0, we have separate id allocator for _tidb_rowid and auto_increment id when AUTO_ID_CACHE=1, see #39041, and ALTER TABLE x AUTO_INCREMENT=x only works on the allocator of auto_increment in this case, but if the table have implicit _tidb_rowid, we should update it's base too to make sure new insert works, else it will report duplicate entry

What is changed and how it works?

  • rebase on both allocators when needed after import

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#46171
3a0b3c3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 18, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added ok-to-test release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1-20230818-v7.1.1 labels Aug 18, 2023
@D3Hunter
Copy link
Contributor

/lgtm

@D3Hunter
Copy link
Contributor

/test pull-br-integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 18, 2023 •
edited

/hold

wait lightning ci

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@tiprow
Copy link

tiprow bot commented Aug 18, 2023

@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.1-20230818-v7.1.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

/test pull-br-integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

/run-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 18, 2023

@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.1-20230818-v7.1.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

/run-integration-br-test

lance6716
lance6716 previously approved these changes Aug 18, 2023
View reviewed changes
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 02:26:03.403062494 +0000 UTC m=+857127.952078478: ☑️ agreed by D3Hunter.
  • 2023-08-18 02:34:52.992646556 +0000 UTC m=+857657.541662543: ☑️ agreed by lance6716.

lichunzhu
lichunzhu previously approved these changes Aug 18, 2023
View reviewed changes
@D3Hunter D3Hunter dismissed stale reviews from lichunzhu and lance6716 via 05205dc August 18, 2023 03:18
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/test all

@tiprow
Copy link

tiprow bot commented Aug 18, 2023

@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.1-20230818-v7.1.1

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

/retest-required

@D3Hunter
Copy link
Contributor

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20230818-v7.1.1@cf44157). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-7.1-20230818-v7.1.1     #46210   +/-   ##
================================================================
  Coverage                               ?   73.4315%           
================================================================
  Files                                  ?       1202           
  Lines                                  ?     376239           
  Branches                               ?          0           
================================================================
  Hits                                   ?     276278           
  Misses                                 ?      82307           
  Partials                               ?      17654

@D3Hunter
Copy link
Contributor

ci pass https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/16111/pipeline/

@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit f40276e into pingcap:release-7.1-20230818-v7.1.1 Aug 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@lichunzhu lichunzhu lichunzhu left review comments

Assignees

@D3Hunter D3Hunter

Labels
approved lgtm ok-to-test release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1-20230818-v7.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ti-chi-bot @D3Hunter @lance6716 @lichunzhu