Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: separate auto_increment ID allocator from _tidb_rowid allocator when AUTO_ID_CACHE=1 #39041

Merged
merged 33 commits into from
Nov 29, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 10, 2022

What problem does this PR solve?

Issue Number: close #982

Problem Summary:

In the past, both _row_id and auto_increment_id share the same allocator, so the behaviour is not compatible with MySQL.
We try to solve it in the past #20708, but that increase the risk of been incompatible to the old TiDB. So we mark it as won't fix. (I have to mention that clustered index relieve some of the cases, and clustered index is enabled by default now, through it does not solve all the issues)

Now we are trying to introduce a MySQL-compatible mode #38449, this is a good time to fix the behaviour. With table option AUTO_ID_CACHE 1, the new implementation is used.

What is changed and how it works?

Seperate auto_increment ID allocator from _tidb_rowid allocator oinly when table option AUTO_ID_CACHE=1 is used.

  1. create table ... AUTO_ID_CACHE 1 ... decides whether to use SepAutoInc by checking AutoIdCache and Version in model.TableInfo
  2. Correct the call side of RowID and AutoIncrementID
  3. If Allocators.Get() find SepAutoInc is not set, it changes AutoIncrementID to RowID; otherwise AutoIncrementID is used

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review November 11, 2022 11:15
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2022
@tiancaiamao
Copy link
Contributor Author

PTAL @bb7133 @tangenta

table/temptable/main_test.go Outdated Show resolved Hide resolved
meta/meta_autoid.go Outdated Show resolved Hide resolved
ddl/column.go Outdated Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor Author

/run-unit-test

2 similar comments
@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@wuhuizuo
Copy link
Contributor

/run-check-dev-2
/run-mysql-test

@tiancaiamao
Copy link
Contributor Author

/run-check_dev_2
/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 19dae1f into pingcap:master Nov 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 1 min 6 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 5 min 15 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 40 tests passed 20 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 10 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 5 min 32 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 21 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the autoid-not-rowid branch November 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB should use separated Allocators for the auto_increment column value and the row ID
7 participants