Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspectkv: rename package inspectkv to admin #4815

Merged
merged 6 commits into from
Oct 20, 2017

Conversation

coocood
Copy link
Member

@coocood coocood commented Oct 18, 2017

This package does more than inspectkv, rename to admin is better.

This package does more than inspectkv, rename to `admin` is better.
@coocood
Copy link
Member Author

coocood commented Oct 18, 2017

@zimulala PTAL

@tiancaiamao
Copy link
Contributor

LGTM

@zimulala
Copy link
Contributor

LGTM
Please fix the conflict.

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2017
@coocood
Copy link
Member Author

coocood commented Oct 19, 2017

@zimulala
PTAL

@shenli
Copy link
Member

shenli commented Oct 19, 2017

LGTM
Please fix CI.

@coocood coocood merged commit c49c2d3 into pingcap:master Oct 20, 2017
@coocood coocood deleted the rename-inspectkv branch October 20, 2017 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants