New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspectkv: rename package `inspectkv` to `admin` #4815

Merged
merged 6 commits into from Oct 20, 2017

Conversation

Projects
None yet
4 participants
@coocood
Member

coocood commented Oct 18, 2017

This package does more than inspectkv, rename to admin is better.

inspectkv: rename package `inspectkv` to `admin`
This package does more than inspectkv, rename to `admin` is better.
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 18, 2017

@zimulala PTAL

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Oct 19, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Oct 19, 2017

LGTM

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Oct 19, 2017

Member

LGTM
Please fix the conflict.

Member

zimulala commented Oct 19, 2017

LGTM
Please fix the conflict.

coocood added some commits Oct 19, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 19, 2017

@zimulala
PTAL

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 19, 2017

Member

LGTM
Please fix CI.

Member

shenli commented Oct 19, 2017

LGTM
Please fix CI.

@coocood coocood merged commit c49c2d3 into pingcap:master Oct 20, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:rename-inspectkv branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment