Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, plan: add unsigned and zerofill flags to field type year #4832

Merged
merged 2 commits into from
Oct 20, 2017
Merged

ddl, plan: add unsigned and zerofill flags to field type year #4832

merged 2 commits into from
Oct 20, 2017

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Oct 19, 2017 •
edited
Loading

Fix #4830 PTAL @XuHuaiyu @breeswish

@shenli
Copy link
Member

shenli commented Oct 19, 2017

LGTM

@shenli
Copy link
Member

shenli commented Oct 19, 2017

/run-all-tests

XuHuaiyu
XuHuaiyu approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu merged commit 2f16fe0 into pingcap:master Oct 20, 2017
@jackysp jackysp deleted the unsigned_year branch January 4, 2018 09:19
@jackysp jackysp added the sig/sql-infra SIG: SQL Infra label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field type year should have unsigned flag
3 participants
@jackysp @shenli @XuHuaiyu