Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gloabl sort: revert "writer upload data in background" #49118

Merged
merged 5 commits into from Dec 4, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 4, 2023

revert #48873

This reverts commit 720ae4b.

What problem does this PR solve?

Issue Number: ref #49117 close #49111

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…ackground (pingcap#48873)"

This reverts commit 720ae4b.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
Copy link

tiprow bot commented Dec 4, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #49118 (1135139) into master (795335a) will increase coverage by 1.0535%.
Report is 5 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49118        +/-   ##
================================================
+ Coverage   71.0442%   72.0977%   +1.0534%     
================================================
  Files          1368       1405        +37     
  Lines        402977     413361     +10384     
================================================
+ Hits         286292     298024     +11732     
+ Misses        96744      96524       -220     
+ Partials      19941      18813      -1128     
Flag Coverage Δ
integration 43.7028% <0.0000%> (?)
unit 71.0440% <ø> (-0.0003%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3829% <0.0000%> (-4.5885%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]Revert "gloabl sort: add more test cases, and writer upload data in b… gloabl sort: revert "writer upload data in background" Dec 4, 2023
@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 4, 2023

/lgtm

Copy link

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 10:06:32.983357664 +0000 UTC m=+1435621.648583860: ☑️ agreed by D3Hunter.
  • 2023-12-04 10:10:58.104159898 +0000 UTC m=+1435886.769386092: ☑️ agreed by ywqzzy.

@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 4, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 9493021 into pingcap:master Dec 4, 2023
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb oom when do some chaos test during add index or import into with global sort
3 participants