Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix tidb crash when shuffleExec quit unexpectedly (#48828) #49147

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48828

What problem does this PR solve?

Issue Number: close #48230

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix tidb crash when shuffleExec quit unexpectedly

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 4, 2023
Copy link

ti-chi-bot bot commented Dec 4, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
@wshwsh12 wshwsh12 closed this Dec 5, 2023
@wshwsh12 wshwsh12 reopened this Mar 11, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 06:21:17.899089669 +0000 UTC m=+252139.426630212: ☑️ agreed by XuHuaiyu.
  • 2024-04-01 06:22:25.040146802 +0000 UTC m=+252206.567687348: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@wshwsh12
Copy link
Contributor

wshwsh12 commented Apr 1, 2024

/retest

1 similar comment
@wshwsh12
Copy link
Contributor

wshwsh12 commented Apr 1, 2024

/retest

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@8445821). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49147   +/-   ##
================================================
  Coverage               ?   73.6486%           
================================================
  Files                  ?       1096           
  Lines                  ?     351439           
  Branches               ?          0           
================================================
  Hits                   ?     258830           
  Misses                 ?      75977           
  Partials               ?      16632           

@ti-chi-bot ti-chi-bot bot merged commit 6db72f2 into pingcap:release-6.5 Apr 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants