New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: refactor cache implement for regexp_like
/regexp_instr
/regexp_replace
#49642
Conversation
…/`regexp_replace`
cfbb1d3
to
05b1a57
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49642 +/- ##
================================================
+ Coverage 70.9796% 71.4575% +0.4779%
================================================
Files 1368 1423 +55
Lines 398699 417368 +18669
================================================
+ Hits 282995 298241 +15246
- Misses 95933 100300 +4367
+ Partials 19771 18827 -944
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test tiprow_fast_test |
@lcwangchao: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuHuaiyu, xzhangxian1008, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #49641
Problem Summary:
After #49584 , we have refactored the implement for function
regexp_substr
. This PR refactors other regexp functions.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.