Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove old regexpBaseFuncSig and rename regexpNewBaseFuncSig to regexpBaseFuncSig #49685

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #49684

Problem Summary:

After #49584 and #49642 the old regexpBaseFuncSig is useless. Now, we can remove it and rename regexpNewBaseFuncSig to regexpBaseFuncSig now.

What changed and how does it work?

remove old regexpBaseFuncSig and rename regexpNewBaseFuncSig to regexpBaseFuncSig

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #49685 (fc33f6a) into master (b1e5d61) will increase coverage by 0.4387%.
Report is 2 commits behind head on master.
The diff coverage is 76.1904%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49685        +/-   ##
================================================
+ Coverage   70.9732%   71.4120%   +0.4387%     
================================================
  Files          1368       1424        +56     
  Lines        398095     415762     +17667     
================================================
+ Hits         282541     296904     +14363     
- Misses        95813     100067      +4254     
+ Partials      19741      18791       -950     
Flag Coverage Δ
integration 43.6916% <76.1904%> (?)
unit 70.9733% <100.0000%> (+<0.0001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3069% <ø> (-5.5971%) ⬇️

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 22, 2023
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 22, 2023

@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 03:48:42.187259227 +0000 UTC m=+1192013.224486156: ☑️ agreed by YangKeao.
  • 2023-12-22 04:52:42.085055044 +0000 UTC m=+1195853.122281956: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 6c4eba0 into pingcap:master Dec 22, 2023
18 checks passed
@lcwangchao lcwangchao deleted the regexp_remove_old branch December 22, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove old regexpBaseFuncSig
5 participants