New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove resolver.go #4988

Merged
merged 29 commits into from Nov 10, 2017

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Nov 2, 2017

refer to #4787
should be merged with pingcap/tidb-test#398
This commit removes resolver.go completely.
Now TiDB resolves table name in preprocessor.go, and resolves column names when building logical plan.

Resolving col name when building logical plan will raise a problem like:

create table t(a int);
prepare stmt from 'select b from t'; // This sql should have caused an error, I'll fix it in next PR.

XuHuaiyu added some commits Nov 2, 2017

Merge branch 'master' of https://github.com/pingcap/tidb into resolver
Conflicts:
	executor/prepared.go
	executor/prepared_test.go
	plan/physical_plan_test.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 2, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Nov 2, 2017

/run-all-test

}
var resolverTests = []resolverTestCase{
{"select c1 from t1", true, ""},

This comment has been minimized.

@hanfei1991

hanfei1991 Nov 2, 2017

Member

Some cases need to move to logicalPlanBuilder TestPlanBuilder

@hanfei1991

hanfei1991 Nov 2, 2017

Member

Some cases need to move to logicalPlanBuilder TestPlanBuilder

Show outdated Hide outdated plan/preprocess.go
Show outdated Hide outdated plan/preprocess.go

XuHuaiyu added some commits Nov 6, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 6, 2017

Contributor

CI failed since #4613 relies on GetResultField of *ast.Join ....
I'll fix it soon.

Contributor

XuHuaiyu commented Nov 6, 2017

CI failed since #4613 relies on GetResultField of *ast.Join ....
I'll fix it soon.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 7, 2017

Contributor

/run-all-tests

Contributor

XuHuaiyu commented Nov 7, 2017

/run-all-tests

XuHuaiyu added some commits Nov 7, 2017

Show outdated Hide outdated new_session_test.go
Show outdated Hide outdated plan/dag_plan_test.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/optimizer.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 7, 2017

Contributor
Contributor

XuHuaiyu commented Nov 7, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 7, 2017

Contributor

/run-all-tests

Contributor

XuHuaiyu commented Nov 7, 2017

/run-all-tests

@XuHuaiyu XuHuaiyu added this to the 1.1 milestone Nov 7, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 7, 2017

Contributor

CI failed since some error messages changed.
I'll try to fix them soon.

Contributor

XuHuaiyu commented Nov 7, 2017

CI failed since some error messages changed.
I'll try to fix them soon.

XuHuaiyu added some commits Nov 8, 2017

Show outdated Hide outdated plan/expression_rewriter.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/preprocess.go
Show outdated Hide outdated plan/preprocess.go

XuHuaiyu added some commits Nov 8, 2017

Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go
break
}
}
if !foundMatch {

This comment has been minimized.

@hanfei1991

hanfei1991 Nov 8, 2017

Member

What's the behaviour of delete a from (select * from t)a, t;

@hanfei1991

hanfei1991 Nov 8, 2017

Member

What's the behaviour of delete a from (select * from t)a, t;

Show outdated Hide outdated plan/preprocess.go

XuHuaiyu added some commits Nov 8, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 8, 2017

Contributor

/run-common-test tidb-test=pr4988
/run-integration-common-tests tidb-test=pr4988

Contributor

XuHuaiyu commented Nov 8, 2017

/run-common-test tidb-test=pr4988
/run-integration-common-tests tidb-test=pr4988

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 8, 2017

Contributor

/run-common-test tidb-test=pr/398
/run-integration-common-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 8, 2017

/run-common-test tidb-test=pr/398
/run-integration-common-tests tidb-test=pr/398

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 8, 2017

Contributor

/run-integration-common-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 8, 2017

/run-integration-common-tests tidb-test=pr/398

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 8, 2017

Contributor

/run-all-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 8, 2017

/run-all-tests tidb-test=pr/398

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Nov 8, 2017

Show outdated Hide outdated executor/prepared_test.go
Show outdated Hide outdated plan/optimizer.go
Show outdated Hide outdated plan/optimizer.go
Show outdated Hide outdated plan/planbuilder.go
Show outdated Hide outdated plan/preprocess.go
Show outdated Hide outdated plan/preprocess.go
Show outdated Hide outdated plan/typeinfer_test.go
@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 9, 2017

Member

LGTM

Member

zimulala commented Nov 9, 2017

LGTM

@zimulala zimulala added the status/LGT1 label Nov 9, 2017

Show outdated Hide outdated executor/prepared_test.go
Show outdated Hide outdated new_session_test.go
@@ -119,9 +119,7 @@ func (e *Execute) optimizePreparedPlan(ctx context.Context, is infoschema.InfoSc
vars.PreparedParams[i] = val
}
if prepared.SchemaVersion != is.SchemaMetaVersion() {
// If the schema version has changed we need to prepare it again,

This comment has been minimized.

@hanfei1991

hanfei1991 Nov 9, 2017

Member

Why remove the comments ?

@hanfei1991

hanfei1991 Nov 9, 2017

Member

Why remove the comments ?

Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/preprocess.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 9, 2017

Contributor
Contributor

XuHuaiyu commented Nov 9, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 9, 2017

Contributor

/run-all-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 9, 2017

/run-all-tests tidb-test=pr/398

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 9, 2017

Contributor

/run-common-test tidb-test=pr/398
/run-integration-common-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 9, 2017

/run-common-test tidb-test=pr/398
/run-integration-common-tests tidb-test=pr/398

XuHuaiyu added some commits Nov 10, 2017

Merge branch 'resolver' of https://github.com/XuHuaiyu/tidb into reso…
…lver

:1�kbQ1
�ý`q!�kb���:q!
@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 10, 2017

Member

LGTM

Member

hanfei1991 commented Nov 10, 2017

LGTM

@hanfei1991 hanfei1991 added status/LGT2 and removed status/LGT1 labels Nov 10, 2017

@zz-jason

LGTM

@coocood coocood merged commit 1521258 into pingcap:master Nov 10, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the XuHuaiyu:resolver branch Nov 10, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment