New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support sql_mode `REAL_AS_FLOAT` #5029

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@spongedu
Contributor

spongedu commented Nov 6, 2017

Support sql_mode REAL_AS_FLOAT for TiDB.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason zz-jason added this to the 1.1 milestone Nov 7, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

LGTM

Member

coocood commented Nov 7, 2017

LGTM

@coocood coocood added status/LGT2 and removed status/LGT1 labels Nov 7, 2017

@coocood

coocood approved these changes Nov 7, 2017

@coocood coocood merged commit 30bcd74 into pingcap:master Nov 7, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:mode_real_as_float branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment