Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support sql_mode REAL_AS_FLOAT #5029

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

spongedu
Copy link
Contributor

@spongedu spongedu commented Nov 6, 2017

Support sql_mode REAL_AS_FLOAT for TiDB.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added this to the 1.1 milestone Nov 7, 2017
@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. contribution This PR is from a community contributor. labels Nov 7, 2017
@coocood
Copy link
Member

coocood commented Nov 7, 2017

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2017
@coocood coocood merged commit 30bcd74 into pingcap:master Nov 7, 2017
@spongedu spongedu deleted the mode_real_as_float branch November 7, 2017 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants