Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add eliminate projections rule after join reorder #50410

Closed
wants to merge 3 commits into from

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Jan 15, 2024

What problem does this PR solve?

Issue Number: ref #50358

Problem Summary:
Described in #50358

What changed and how does it work?

A quick fix to pass existing regression test. Since join reorder may add new projections, add projection eliminator rule after it. Had tried to change column prune rule to keep at least one column for logical projection, but failed:

  1. Keep one of the original columns. In this way, the children of the logical projection needs to output the specific column which is useless, and will affect the plan of this following sql which is supposed to eliminate apply plan node:
    select count(1) from (select (select count(t1.a) as a from t t1 where t1.c = t2.c) as a from t t2) as t3
  2. Use constant-one expression. In this way, some projections under aggregation will not be eliminated. Because the logicalProjection can be eliminated only when all its expressions are columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2024
Copy link

ti-chi-bot bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign djshow832 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Jan 15, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 15, 2024

/cc @elsa0520 @hawkingrei

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Merging #50410 (c5685c1) into master (5faf86c) will decrease coverage by 16.4581%.
Report is 740 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50410         +/-   ##
=================================================
- Coverage   70.0709%   53.6128%   -16.4581%     
=================================================
  Files          1444       1553        +109     
  Lines        420010     586900     +166890     
=================================================
+ Hits         294305     314654      +20349     
- Misses       105423     248386     +142963     
- Partials      20282      23860       +3578     
Flag Coverage Δ
integration 21.8312% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5769% <ø> (+5.9037%) ⬆️

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2024
@yibin87 yibin87 changed the title planner: avoid pruning all outputs for LogicalProjection planner: add eliminate projections rule after join reorder Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
Copy link

ti-chi-bot bot commented Feb 3, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 10, 2024

@yibin87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev c5685c1 link true /test check-dev
idc-jenkins-ci-tidb/build c5685c1 link true /test build
idc-jenkins-ci-tidb/check_dev_2 c5685c1 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test c5685c1 link true /test mysql-test
pull-integration-ddl-test c5685c1 link true /test pull-integration-ddl-test
pull-mysql-client-test c5685c1 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test c5685c1 link true /test unit-test
pull-br-integration-test c5685c1 link true /test pull-br-integration-test
pull-lightning-integration-test c5685c1 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yibin87 yibin87 closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 needs-cherry-pick-release-7.5 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant