remove read-only statement from transaction auto retry (#5026) #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@wentaoxu please fix the error. |
coocood
reviewed
Nov 10, 2017
executor/compiler.go
Outdated
| return &ExecStmt{ | ||
| InfoSchema: infoSchema, | ||
| Plan: finalPlan, | ||
| Expensive: stmtCount(stmtNode, finalPlan, ctx.GetSessionVars().InRestrictedSQL), | ||
| Cacheable: plan.Cacheable(stmtNode), | ||
| Text: stmtNode.Text(), | ||
| ReadOnly: ast.IsReadOnly(readOnlyCheckStmt), | ||
| // this should not be 'plan.execute' | ||
| ReadOnly: ast.IsReadOnly(stmtNode), |
There was a problem hiding this comment.
It can be plan.Execute
There are two types of prepared statement binary and text.
|
@wentaoxu Any update? |
* *: Ignore readonly statement when retrying * remove explain statement from retry * remove all select statement from retry except It has setvar functions * remove execute statement from retry if it is read-only statement
wentaoxu
force-pushed
the
release-1.0
branch
from
f4b3d6a
to
39d7430
Compare
|
PTAL @coocood, I get the prepared ast from session context and check if the ast is read-only. if plan cache merge into release-1.0, these codes can be deleted. |
|
LGTM |
|
/run-all-tests tikv=release-1.0 tidb-test=release-1.0 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: Ignore readonly statement when retrying
remove explain statement from retry
remove all select statement from retry except It has setvar functions
remove execute statement from retry if it is read-only statement