Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: adapt to the go1.21 map loadFactor setting value (#50545) #50581

Merged

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Jan 19, 2024

What problem does this PR solve?

This is an cherry-pick of #50545 to relase-7.5

Issue Number: close #50544 and #50552

Problem Summary:
This PR is trivial.
As the golang/go#63438 indicates load factor of map in 1.21 would be 6 rather than 6.5 in other version. The whole test of TestaggPartiualResultMap depends on the assumption that load factor of map in golang would be 6.5.
To adopt this breaking behavior, the codebase of tidb should makes changes accordingly.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

Hi @zhexuany. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 19, 2024

Hi @zhexuany. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XuHuaiyu
Copy link
Contributor

/ok-to-test

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@8aa2293). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50581   +/-   ##
================================================
  Coverage               ?   72.0576%           
================================================
  Files                  ?       1400           
  Lines                  ?     407131           
  Branches               ?          0           
================================================
  Hits                   ?     293369           
  Misses                 ?      94077           
  Partials               ?      19685           
Flag Coverage Δ
unit 72.0576% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2987% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 14:10:40.108097322 +0000 UTC m=+883481.672395027: ☑️ agreed by XuHuaiyu.
  • 2024-01-25 02:46:25.186010617 +0000 UTC m=+1015226.750308307: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 44efbde into pingcap:release-7.5 Jan 25, 2024
18 checks passed
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
Copy link

ti-chi-bot bot commented Feb 2, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants