Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: adapt to the go1.21 map loadFactor setting value (#50545) #50567

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50545

What problem does this PR solve?

Issue Number: close #50544 and #50552

Problem Summary:

What changed and how does it work?

This PR is trivial.
As the discussion indicates load factor of map in 1.21 would be 6 rather than 6.5 in other version. The whole test of TestaggPartiualResultMap depends on the assumption that load factor of map in golang would be 6.5.
To adopt this breaking behavior, the codebase of tidb should makes changes accordingly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 18, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 b6fe086 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test b6fe086 link true /test unit-test
idc-jenkins-ci-tidb/build b6fe086 link true /test build
idc-jenkins-ci-tidb/mysql-test b6fe086 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev b6fe086 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhexuany
Copy link
Contributor

@XuHuaiyu could you please approve this cherry-pick?

@zhexuany
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@zhexuany you're not a member of org pingcap

Copy link

ti-chi-bot bot commented Jan 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2024
Copy link

ti-chi-bot bot commented Jan 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-21 15:28:56.900566764 +0000 UTC m=+715378.464864454: ☑️ agreed by AilinKid.

@zhexuany
Copy link
Contributor

zhexuany commented Jan 22, 2024

@AilinKid Does not have the privilege to modify changes in tichibot's repo.

Is it possible close this cherry-pick request and approve the change in this CP #50581.

@ti-chi-bot ti-chi-bot closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants