-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,bootstrap: add tidb_index_usage
table and cluster_tidb_index_usage
table
#50824
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50824 +/- ##
================================================
+ Coverage 70.4915% 72.8627% +2.3712%
================================================
Files 1465 1468 +3
Lines 433404 441194 +7790
================================================
+ Hits 305513 321466 +15953
+ Misses 108645 99655 -8990
- Partials 19246 20073 +827
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tidb_index_usage
table, cluster_tidb_index_usage
table and sys.schema_unused_indexes
viewtidb_index_usage
table, cluster_tidb_index_usage
table and sys.schema_unused_indexes
view | tidb-test=pr/2287
a592cfc
to
b7f3f40
Compare
f01cf09
to
7dfe820
Compare
tidb_index_usage
table, cluster_tidb_index_usage
table and sys.schema_unused_indexes
view | tidb-test=pr/2287tidb_index_usage
table, cluster_tidb_index_usage
table | tidb-test=pr/2287
tidb_index_usage
table, cluster_tidb_index_usage
table | tidb-test=pr/2287tidb_index_usage
table, cluster_tidb_index_usage
table
7dfe820
to
f58713f
Compare
aa74895
to
95d749e
Compare
tidb_index_usage
table, cluster_tidb_index_usage
tabletidb_index_usage
table and cluster_tidb_index_usage
table
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
95d749e
to
3b7b564
Compare
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rows := make([][]types.Datum, 0, 100) | ||
checker := privilege.GetPrivilegeManager(ctx) | ||
|
||
for _, schema := range schemas { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to consider pushdown predicate to make this InformationSchema table work well when there are a huge number tables. like we do for saas customer: #50779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #50823
What changed and how does it work?
information_schema.tidb_index_usage
+cluster_tidb_index_usage
Check List
Tests
Documentation
Release note