ddl: Deal with discrete handles #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Nov 14, 2017
ddl/index.go
Outdated
| defaultTaskHandleCnt = 128 | ||
| maxTaskHandleCnt = 2048 |
|
We should also decrease the batch size if the actual count is too large. |
|
@zimulala |
|
The threshold to decrease can be 1024 actual keys, but the handle range can be as large as 1 million. |
|
@coocood PTAL |
shenli
reviewed
Nov 15, 2017
ddl/index.go
Outdated
| @@ -525,6 +529,13 @@ type handleInfo struct { | |||
| endHandle int64 | |||
| } | |||
|
|
|||
| func chooseInt64(baseHandle, batch int64) int64 { | |||
There was a problem hiding this comment.
Rename it to getEndHandle is better.
shenli
reviewed
Nov 16, 2017
ddl/index.go
Outdated
| } | ||
| } | ||
|
|
||
| func getCountAndHandle(workers []*worker) (int64, int64, bool, error) { | ||
| taskAddedCount, nextHandle := int64(0), workers[0].taskRange.startHandle | ||
| var err error | ||
| var isEnd bool | ||
| lessMinWorkers := 0 |
There was a problem hiding this comment.
s/lessMinWorkers/starvingWorkers/
| nextHandle = ret.outOfRangeHandle | ||
| isEnd = ret.isAllDone | ||
| } | ||
|
|
||
| // Adjust the worker's batch size. |
There was a problem hiding this comment.
Add more comment here to describe why we should increase the batch size. What is the problem we are trying to solve.
There was a problem hiding this comment.
Done.
PTAL @shenli
ddl/index.go
Outdated
| defaultTaskHandleCnt = 128 | ||
| maxTaskHandleCnt = 1 << 20 |
|
LGTM |
coocood
previously approved these changes
Nov 20, 2017
|
/run-all-tests |
|
/run-unit-test |
tiancaiamao
approved these changes
Nov 20, 2017
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Nov 20, 2017
* ddl: deal with discrete handles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been added to the function of
TestAddIndex.