Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl,domain: deal with discrete handles and close DDL when creating failed #5155

Merged
merged 2 commits into from Nov 20, 2017
Merged

ddl,domain: deal with discrete handles and close DDL when creating failed #5155

merged 2 commits into from Nov 20, 2017

Conversation

zimulala
Copy link
Contributor

Cherry pick #5102 and #5128

@zimulala
Copy link
Contributor Author

/run-all-tests -tidb-test=release-1.0

winoros
winoros reviewed Nov 20, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2017
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2017
@winoros winoros merged commit 7a7995b into pingcap:release-1.0 Nov 20, 2017
@zimulala zimulala deleted the ddl-domian branch November 20, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimulala @tiancaiamao @winoros