server: fix incorrect setting of health status

[shenqidebaozi]

What problem does this PR solve?

Issue Number: close #51596

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix that when the server is not started, it should not default to a healthy state

[ti-chi-bot]

Hi @shenqidebaozi. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @shenqidebaozi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hawkingrei]

/ok-to-test

[hawkingrei]

/check-issue-triage-complete

[codecov]

Codecov Report

Merging #51595 (511090d) into master (54cca35) will increase coverage by 0.2782%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51595        +/-   ##
================================================
+ Coverage   72.5409%   72.8192%   +0.2782%     
================================================
  Files          1467       1467                
  Lines        363094     436617     +73523     
================================================
+ Hits         263392     317941     +54549     
- Misses        80380      98690     +18310     
- Partials      19322      19986       +664     

Flag	Coverage Δ
integration	48.8587% <100.0000%> (?)
unit	70.4811% <100.0000%> (-1.9340%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	51.5171% <ø> (+5.0647%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-07 23:59:45.294667138 +0000 UTC m=+384412.316913523: ☑️ agreed by hawkingrei.
• 2024-03-08 02:16:29.574346282 +0000 UTC m=+392616.596592669: ☑️ agreed by Defined2014.

[hawkingrei]

/cherrypick release-7.5

[hawkingrei]

/cherrypick release-7.1

[ti-chi-bot]

@hawkingrei: new pull request created to branch release-7.5: #51623.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@hawkingrei: new pull request created to branch release-7.1: #51624.

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[hawkingrei]

/cherrypick release-6.5

[ti-chi-bot]

@hawkingrei: new pull request created to branch release-6.5: #51632.

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.