Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix incorrect setting of health status (#51595) #51623

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51595

What problem does this PR solve?

Issue Number: close #51596

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix that when the server is not started, it should not default to a healthy state

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 8, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei hawkingrei force-pushed the cherry-pick-51595-to-release-7.5 branch from d3abb52 to cd452cd Compare March 18, 2024 03:28
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 18, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2024
@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@2be93d3). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51623   +/-   ##
================================================
  Coverage               ?   71.9827%           
================================================
  Files                  ?       1408           
  Lines                  ?     409094           
  Branches               ?          0           
================================================
  Hits                   ?     294477           
  Misses                 ?      94798           
  Partials               ?      19819           
Flag Coverage Δ
unit 71.9827% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3534% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2024
Copy link

ti-chi-bot bot commented Mar 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-18 03:29:44.180706719 +0000 UTC m=+1261011.202953107: ☑️ agreed by hawkingrei.
  • 2024-03-18 04:31:26.675277819 +0000 UTC m=+1264713.697524207: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 5c811f6 into pingcap:release-7.5 Mar 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants