lightning: merge configuration for preprocess duplicate detection and post-import conflict detection #51710
Conversation
This reverts commit 3fda42b.
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/ddl/ingest/config.go
Outdated
| @@ -63,10 +63,12 @@ func genConfig(ctx context.Context, memRoot MemRoot, jobID int64, unique bool, r | |||
| adjustImportMemory(ctx, memRoot, cfg) | |||
| cfg.Checkpoint.Enable = true | |||
| if unique { | |||
| cfg.TikvImporter.DuplicateResolution = lightning.DupeResAlgErr | |||
| if cfg.TikvImporter.Backend == lightning.BackendLocal { | |||
There was a problem hiding this comment.
add-index always use local backend, maybe remove this. below too
| @@ -0,0 +1,6 @@ | |||
| [tikv-importer] | |||
| # Set on-duplicate=error to force using insert statement to write data. | |||
There was a problem hiding this comment.
| # Set on-duplicate=error to force using insert statement to write data. |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lyzx2001: GitHub didn't allow me to request PR reviews from the following users: easonn7. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Benjamin2037, D3Hunter, easonn7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51036
Problem Summary:
What changed and how does it work?
Merge preprocess duplicate detection and post-import conflict detection.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.