Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go: fix data race that may cause tikv/client-go client_batch panic #51729

Merged
merged 2 commits into from Apr 3, 2024

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Mar 13, 2024

What problem does this PR solve?

Issue Number: close #39169

Problem Summary: See tikv/client-go#1219

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
Copy link

tiprow bot commented Mar 13, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #51729 (13d7fd2) into master (a57ebeb) will increase coverage by 1.2034%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51729        +/-   ##
================================================
+ Coverage   72.1248%   73.3282%   +1.2034%     
================================================
  Files          1467       1468         +1     
  Lines        426605     433485      +6880     
================================================
+ Hits         307688     317867     +10179     
+ Misses        99728      95808      -3920     
- Partials      19189      19810       +621     
Flag Coverage Δ
integration 48.8436% <ø> (?)
unit 70.9803% <ø> (-0.0320%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.4877% <ø> (+0.9033%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 changed the title [WIP]client-go: fix issue about enable-forwarding and concurrency request limit client-go: fix issue about enable-forwarding and concurrency request limit Apr 2, 2024
@ti-chi-bot ti-chi-bot bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Apr 2, 2024
@crazycs520 crazycs520 changed the title client-go: fix issue about enable-forwarding and concurrency request limit client-go: fix data race that may cause tikv/client-go client_batch panic Apr 2, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@zyguan
Copy link
Contributor

zyguan commented Apr 2, 2024

/retest

Copy link

tiprow bot commented Apr 2, 2024

@zyguan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zyguan
Copy link
Contributor

zyguan commented Apr 2, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Apr 2, 2024
Copy link

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-02 12:31:31.18842947 +0000 UTC m=+360752.715970008: ☑️ agreed by zyguan.
  • 2024-04-03 02:00:41.36428451 +0000 UTC m=+409302.891825054: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 8a10278 into pingcap:master Apr 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb server connection panic occurs frequently with configuration "enable-forwarding = true"
3 participants