Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: remove misleading log info #52145

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Mar 27, 2024

What problem does this PR solve?

Issue Number: close #50837

Problem Summary:

What changed and how does it work?

Remove the misleading entry in br log as described in the issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2024
Copy link

tiprow bot commented Mar 27, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #52145 (8735b3a) into master (1549ea6) will decrease coverage by 15.9669%.
Report is 18 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52145         +/-   ##
=================================================
- Coverage   70.7412%   54.7743%   -15.9669%     
=================================================
  Files          1486       1599        +113     
  Lines        439485     610567     +171082     
=================================================
+ Hits         310897     334434      +23537     
- Misses       109161     252854     +143693     
- Partials      19427      23279       +3852     
Flag Coverage Δ
integration 36.7037% <100.0000%> (?)
unit 70.4395% <0.0000%> (-0.1189%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5995% <100.0000%> (+5.7570%) ⬆️

@BornChanger
Copy link
Contributor Author

/cc @3pointer @Leavrth @YuJuncen

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 08:08:31.104140806 +0000 UTC m=+2141738.126387194: ☑️ agreed by 3pointer.
  • 2024-03-28 08:10:24.868723629 +0000 UTC m=+2141851.890970018: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 5f53c70 into pingcap:master Mar 28, 2024
31 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: confusing message of full backup
3 participants