Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: confusing message of full backup #50837

Closed
BornChanger opened this issue Jan 31, 2024 · 3 comments · Fixed by #52145
Closed

br: confusing message of full backup #50837

BornChanger opened this issue Jan 31, 2024 · 3 comments · Fixed by #52145
Labels
component/br This issue is related to BR of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@BornChanger
Copy link
Contributor

BornChanger commented Jan 31, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run full backup with --ratelimit is specified.

2. What did you expect to see? (Required)

Backup job is run in serial

3. What did you see instead (Required)

Confusing messages show in the output like

[2024/01/30 17:26:19.926 +08:00] [WARN] [logging.go:253] ["setting --ratelimitand--concurrencyat the same time, ignoring--concurrency: --ratelimit forces sequential (i.e. concurrency = 1) backup"] [ratelimit=134.2MB/s] [concurrency-specified=1]
[2024/01/30 17:26:25.222 +08:00] [INFO] [client.go:874] ["backup range started"] [range-sn=0] [startKey=74800000000000010B5F7201] [endKey=74800000000000010B5F72FB] [rateLimit=134217728] [concurrency=4]

4. What is your TiDB version? (Required)
@BornChanger BornChanger added the type/bug The issue is confirmed as a bug. label Jan 31, 2024
@BornChanger
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Jan 31, 2024
@BornChanger
Copy link
Contributor Author

/severity moderate

@BornChanger
Copy link
Contributor Author

BornChanger commented Jan 31, 2024 •
edited
Loading

We need to remove the attribute of concurrency for the tikv pb request because it is never used.

@BornChanger BornChanger mentioned this issue Mar 27, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@BornChanger
br: remove misleading log info (#52145)
5f53c70 
close #50837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: remove misleading log info BornChanger/tidb
1 participant
@BornChanger