Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix wrong pointer used when async load stats #52169

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 27, 2024

What problem does this PR solve?

Issue Number: close #51856

Problem Summary:

What changed and how does it work?

The newly created column stats is colHist instead of c.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #52169 (a6abee7) into master (7a2f1cc) will decrease coverage by 16.0388%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52169         +/-   ##
=================================================
- Coverage   70.7383%   54.6995%   -16.0388%     
=================================================
  Files          1489       1600        +111     
  Lines        439999     609650     +169651     
=================================================
+ Hits         311248     333476      +22228     
- Misses       109286     252952     +143666     
- Partials      19465      23222       +3757     
Flag Coverage Δ
integration 36.5939% <20.0000%> (?)
unit 70.4498% <100.0000%> (-0.0996%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5864% <ø> (+5.7329%) ⬆️

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 01:01:14.579905605 +0000 UTC m=+2116101.602151993: ☑️ agreed by hi-rustin.
  • 2024-03-28 02:46:16.031733351 +0000 UTC m=+2122403.053979734: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 9104291 into pingcap:master Mar 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestAnalyzePartitionTableWithDynamicMode
3 participants