lightning: merge conflict record tables for preprocess duplicate detection and post-import conflict detection #52307
Conversation
…detection and post-import conflict detection
ti-chi-bot
bot
added
release-note-none
do-not-merge/work-in-progress
|
Hi @lyzx2001. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52307 +/- ##
================================================
+ Coverage 72.1369% 74.3866% +2.2496%
================================================
Files 1467 1493 +26
Lines 426605 450483 +23878
================================================
+ Hits 307740 335099 +27359
+ Misses 99681 94498 -5183
- Partials 19184 20886 +1702
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 9cfd852. revert merge tables
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-lightning-integration-test |
lyzx2001
changed the title
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @lance6716 @D3Hunter |
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // due to we use batch insert, we can't know which row is duplicated. | ||
| if c.MaxRecordRows >= 0 { | ||
| // only warn when it is set by user. | ||
| log.L().Warn(`Cannot record duplication (conflict.max-record-rows > 0) when use tikv-importer.backend = \"tidb\" and conflict.strategy = \"replace\". |
There was a problem hiding this comment.
this behaviour also changed. In the old behaviour tidb backend + replace will see error if set max-record-rows, the error will tell the user can't find the error details in conflict table in advance. Now the user will not see the error. Please double check with PM.
There was a problem hiding this comment.
PM confirmed that the user will no longer see this error. Instead there will be a warning in the log
|
/test pull-lightning-integration-test |
|
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, D3Hunter, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label needs-cherry-pick-release-8.1 |
|
In response to a cherrypick label: new pull request created to branch |
…ction and post-import conflict detection (pingcap#52307) ref pingcap#52306
| "(tidb-lightning\\.toml)$": | ||
| approvers: | ||
| - sig-critical-approvers-tidb-lightning |
There was a problem hiding this comment.
@lyzx2001 you forgot to move this part into lightning/OWNERS.
What problem does this PR solve?
Issue Number: ref #52306
ref #52393
Problem Summary:
What changed and how does it work?
Merge conflict record tables for preprocess duplicate detection and post-import conflict detection.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.