Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: update lightning/OWNERS for moving lightning directory out of br #52745

Merged
merged 1 commit into from Apr 19, 2024

Conversation

lyzx2001
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #52744

Problem Summary:
lightning/OWNERS is not correctly updated when moving lightning directory out of br.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
Copy link

tiprow bot commented Apr 19, 2024

Hi @lyzx2001. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyzx2001
Copy link
Contributor Author

/check-issue-triage-complete

@lyzx2001
Copy link
Contributor Author

/cc @lance6716

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #52745 (0279009) into master (14c5a78) will decrease coverage by 0.0254%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52745        +/-   ##
================================================
- Coverage   72.3249%   72.2995%   -0.0254%     
================================================
  Files          1473       1495        +22     
  Lines        427453     435603      +8150     
================================================
+ Hits         309155     314939      +5784     
- Misses        99031     100724      +1693     
- Partials      19267      19940       +673     
Flag Coverage Δ
integration 46.6053% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.1600% <ø> (ø)

Copy link

ti-chi-bot bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 03:00:29.612746448 +0000 UTC m=+566248.723792894: ☑️ agreed by D3Hunter.
  • 2024-04-19 03:09:16.714846089 +0000 UTC m=+566775.825892538: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit e917aa6 into pingcap:master Apr 19, 2024
3 of 6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #52749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lightning/OWNERS is not correctly updated when moving lightning directory out of br
4 participants