Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: make alter database set tiflash replica skip sequence and view #52348

Merged
merged 1 commit into from Apr 12, 2024

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Apr 4, 2024

What problem does this PR solve?

Issue Number: close #51990

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2024
Copy link

tiprow bot commented Apr 4, 2024

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Apr 4, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Apr 4, 2024
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Apr 8, 2024

/cc @mjonss

@ti-chi-bot ti-chi-bot bot requested a review from mjonss April 8, 2024 01:26
@jiyfhust
Copy link
Contributor Author

/cc @tangenta @Defined2014

Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-07 02:19:03.229884985 +0000 UTC m=+756004.757425526: ☑️ agreed by zimulala.
  • 2024-04-12 02:01:38.050402757 +0000 UTC m=+1186959.577943303: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 3fff0f2 into pingcap:master Apr 12, 2024
25 checks passed
@jiyfhust jiyfhust deleted the fix_alter_db_tiflash branch April 12, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER DATABASE ... SET TIFLASH REPLICA will add tiflash replica to SEQUENCE table unexpectly
3 participants