planner: fix missing array clone when building table filter for mv index access path #52613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
do-not-merge/needs-triage-completed
size/M
|
/retest |
AilinKid
approved these changes
Apr 15, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52613 +/- ##
================================================
+ Coverage 72.3397% 74.7058% +2.3661%
================================================
Files 1470 1470
Lines 427158 434844 +7686
================================================
+ Hits 309005 324854 +15849
+ Misses 98883 89774 -9109
- Partials 19270 20216 +946
Flags with carried forward coverage won't be shown. Click here to find out more.
|
winoros
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
3AceShowHand
pushed a commit
to 3AceShowHand/tidb
that referenced
this pull request
Apr 16, 2024
…dex access path (pingcap#52613) close pingcap#52609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #52609
Problem Summary:
The
slices.Delete()below will unexpectedly modify the inputallConds.What changed and how does it work?
Use
slices.Clone()to make sure a new array is allocated.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.